LineReader

LineReader copied to clipboard

Fixed a simple leak

1

Not sure where the original NSDataExtensions lives, but as Stackoverflow sends a few people here I thought I'd send this.

hotwoofy

LineReader stops reading when it hits a character like "É" or "ñ"

11

So you have a textfile such as: diner restaurant lunch-spot greasy spoon café **// "é" character** coffee shop cafeteria LineReader stops reading when it hits the "café" line above. Never...

pkamb

Consider <NSFastEnumeration> conformance

1

It'd be an interesting thing to make FileReader conform to ``, so you could do: ``` FileReader *r = [[FileReader alloc] initWithFilePath:pathToFile]; for (NSString *line in r) { NSLog(@"line: %@",...

davedelong

Naming of things

1

While it uglifies the code, it is best practice to prefix both class names and any category methods with some uniquish characters. JJD would be appropriate. Without namespaces in Cocoa,...

levous

The use and meaning of local variables in `FileReader` `readline` and `readLineBackwards` are not consistent. Especially, the character position at which the reader sits after one while loop in `readLineBackwards`...

johnjohndoe