johnjcasey

Ack, taking a look

This is a really interesting enhancement, but it goes to the core of a Beam transform. Do you have a design document for this? I want to make sure the...

I've been looking into this, and it is starting to seem like python triggers need to be reworked to some extent

it looks like afterAny simply doesn't fire correctly at all, and has never done so

I am not, I wasn't able to understand how python triggers work (or dont) in the fixit week.

This suite is designed to run performance tests, and collect metrics against our released branches. We don't want to add master-branch metrics to our results

@Abacn @ahmedabu98 could you take a look at this?

Yeah, unfortunately Gauges work in Beam, but are not implemented in Dataflow properly. @celeste-zeng might have more up to date information here

Its still worth setting it in beam so if Dataflow implements Gauges the results will be piped through

The change itself LGTM though