johnjcasey

Thanks for finding this and adding improved logs. This LGTM, please LMK if there is any reason to hold off on merging, otherwise I'll merge this in tomorrow

@reuvenlax

Right now it looks like this is failing to compile, and spotless is also failing. Can you address these?

I'm not sure that simply using endOffsets would work in all cases. It may make sense to instead have the caller of this method try to handle getting a correct...

Essentially. This method is public, so we shouldn't change the general pattern here. I would add a new method that calls this, but tries for end offset if it gets...

Please add the license string, and respond to Rebo's comments

Is there any documentation on where we use GAX, or a pointer to a design pattern for this?

Got it. I suppose I will need to do some research on executor options to know which one is the best for this use case

@lukecwik do you have a recommendation on executors to try?

A somewhat simple change would be to update the various get methods in BigQueryServicesImpl to be cached. If you pass in the same options, you get the existing client instance....