John Holdun

Results 36 comments of John Holdun

Thanks for your contribution! Unfortunately I still see circular dependency warnings with this PR, and there are some changes in there that seem unrelated to the warning whose intentions I...

Hello! This will be fixed when we ship EPUB support, which we're tracking in #669. We're using a different method of including images that seems to work much more reliably.

Hello there! I couldn't recreate this issue and haven't heard any other reports of it. If you're still having trouble, please feel free to comment again on this issue or...

Interesting, what's the use case here? Given that Trimmings directives deal with individual DOM nodes fetched from already-rendered HTML, I'm not sure what a virtual DOM gets us that isn't...

> Or maybe Remove could be extended to accept a delay value. I think another way to handle this is to add this hypothetical "auto" directive to a button that...

This is a great suggestion and pairs nicely with #16

Transitions are, in theory, supported by the lifecycle-based classes that Trimmings adds while fetching and replacing content, but I honestly haven't done too much experimentation here to confirm that what's...

Can you solve this problem by using `` instead of `toggle`? Alternatively, you could write some Javascript that listens for `turbolinks:load` and toggles your element by sending a `click` event....

Thanks for noting this! I've just updated a lot of dependencies in #687. There's still one vulnerability listed for cheerio, which is both a critical piece of this project and...

Hi, there was a bug in the most recent version (published today) that somehow managed to make its way past our QA and Google's. We submitted an updated version with...