John Hawkinson comments

Results 78 comments of


                                            John Hawkinson

[generic] misc. fixes (lazyYT test, first_bytes whitespace)

@dstftw, did you mean to commit half of this only?

Migrate http client from requests to httpx async client

I feel like it was alluded to above, but what's wrong with synchronous wrappers around asynchronous core functions? > * Maybe moving the PACER libraries out to their own tool...

Migrate http client from requests to httpx async client

> > What's wrong with synchronous wrappers around asynchronous core functions? > > Well, it's just kind of ugly? Everybody that uses Juriscaper would have to sprinkle little `async_to_sync` wrappers...

feat(acms parser): Adds a parser class to handle attachment pages.

Yeah, I'll try to look at this ~early~ tomorrow ~morning~. **Edit:** That was unrealistic, but hopefully late today?

feat(acms parser): Adds a parser class to handle attachment pages.

My bad I got distracted with Thanksgiving and failed to come back. I'll try to take a good look at this shortly.

feat(acms parser): Adds a parser class to handle attachment pages.

> @grossir thanks for the review. I've applied your suggestions about the example files. 👍 Err, the test case files (which are not really "examples") were deliberately not `.json` per...

Allow unlimited alerts for those with .edu emails

> 1. How do we verify if students are sharing that link all over the place? I think the easiest way is that when we get the webhook in step...

Collect judge data interactively instead of hand-editing judges.json?

I think the pull-request workflow is sufficiently painful for images that putting any effort into a web form would be much preferable.