elibphonenumber icon indicating copy to clipboard operation
elibphonenumber copied to clipboard

turned off warnings as errors

Open cystbear opened this issue 7 years ago • 6 comments

cystbear avatar May 16 '17 11:05 cystbear

Hi @cystbear! Why did you submit this PR? Is the warnings as errors flag causing you issues?

johnhamelink avatar May 22 '17 13:05 johnhamelink

Exactly, this flag causes an error. Furthermore, compile commands for other OSes (e.g. FreeBSD / Darwin) has not this flag.

cystbear avatar May 22 '17 13:05 cystbear

@cystbear Could you let me know what warning is causing the error? It would be better for us to fix the warning than to turn off the flag if possible! I'm using this in Darwin without an issue.

johnhamelink avatar May 22 '17 13:05 johnhamelink

Sure, case Darwin hasn't -Werror flag. Btw, I'll provide error text soon.

cystbear avatar May 22 '17 13:05 cystbear

Thank you! :smile:

johnhamelink avatar May 22 '17 13:05 johnhamelink

@cystbear did you ever get a chance to provide that error so I can help fix it?

johnhamelink avatar Jul 14 '17 15:07 johnhamelink