atom-rainbow icon indicating copy to clipboard operation
atom-rainbow copied to clipboard

Is there a reason you are using overlays here?

Open olleicua opened this issue 7 years ago • 4 comments

I feel like it should be possible to do this without overlays by adding color classes to anything that matches span.syntax--bracket.. I'll dig in a bit more here..

olleicua avatar Oct 17 '17 01:10 olleicua

That was my first idea... but not all syntax's are the same, and some don't differentiate between opening and closing brackets.

johngeorgewright avatar Oct 17 '17 08:10 johngeorgewright

I seems like we should be able to make our own syntax for this..

olleicua avatar Oct 17 '17 13:10 olleicua

That's not a bad shout. I'm assuming, though, that you can't have multiple Languages assigned to one file. Can you extend others? Or would it best to approach the owners of current languages to add new classes to them?

johngeorgewright avatar Oct 18 '17 09:10 johngeorgewright

I would hope for the former.. the documentation is less good than I was hoping..

On 18 October 2017 at 05:29, John Wright [email protected] wrote:

That's not a bad shout. I'm assuming, though, that you can't have multiple Languages assigned to one file. Can you extend others? Or would it best to approach the owners of current languages to add new classes to them?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/johngeorgewright/atom-rainbow/issues/5#issuecomment-337523419, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNhVr1JvJ-srLfQGopKF4PK2aMH2a9rks5stcUDgaJpZM4P7ccx .

olleicua avatar Oct 18 '17 14:10 olleicua