JSONKit icon indicating copy to clipboard operation
JSONKit copied to clipboard

Supporting gzip decompression

Open shobhitpuri opened this issue 10 years ago • 0 comments

Hi

Thanks for the awesome library. I was wondering that should the support for GZIP decompression be added to master? I could see in the "experimental" branch that a commit has been made regarding supporting GZIP decompression: https://github.com/johnezang/JSONKit/commit/d858de69a10672366a6637a44c14e90b7aef04c4. However that branch is too old and does not support running 64bit. When I run on XCode, it gives depreciation errors like:

JSONKit.m:2731:31: error: direct access to Objective-C's isa is deprecated in favor of 
object_getClass()   [-Werror,-Wdeprecated-objc-isa-usage] 
if(JK_EXPECT_T(object->isa == encodeState->fastClassLookup.stringClass))     {
             isClass = JKClassString;    
 }
 31: Direct access to Objective-C's isa is deprecated in favor of object_getClass()
 3: Expanded from macro 'JK_EXPECT_T'
 5: Expanded from macro 'JK_EXPECTED'

The master branch which supports running on 64bit architectures doesn't have the above commit related to gzip. Since a lot has changed since then, cherry picking the specific commit from the experimental branch to master is giving lots of conflicts. Can anyone please give a direction as to how can gzip decompression be supported?

Thanks so much. Regards

shobhitpuri avatar Jun 09 '15 21:06 shobhitpuri