johnd0e
johnd0e
Please rebase your additions on `master` branch. And it'd be nice to include here some screenshot of plugin in work.
> and only considers the first three points. Wrong. All non-triangles should be rejected.
I have no suggestion on this, as I never seen your plugin at work. Consider this https://github.com/IITC-CE/ingress-intel-total-conversion/pull/254#issuecomment-530770226
> That's it rebased on master, but now it doesn't work To make it work can cherry-pick this commit https://github.com/johnd0e/ingress-intel-total-conversion/commit/55c52bcbf2f57a2d201443033379f748ea4463f0
Why not. It will merge clean.
No, that will not merge clean. You should first cherry-pick https://github.com/johnd0e/ingress-intel-total-conversion/commit/55c52bcbf2f57a2d201443033379f748ea4463f0, than rebase your changes on top of it.
Now we are at least able to review the PR. (I cannot give any forward promise that we accept it)
2. On portal click `renderPortalDetails` is called thrice: - render cached data immediately - render response from server (onSuccess ) - `onSuccess` also results in reparse entity -> `portalDetailLoaded` ->...
3. `portalSelected` may be called often - on explicit user action (another click on same portal). Pretty obvious case - on unobvious internal reasons, e.g. - explicit click causes `portalSelected`,...
Thoughts: 1. We should consider that all the code relies on that `renderPortalDetails` will make portal current. When portal in not on map yet - that can be deferred, with...