John Cronan

Results 25 comments of John Cronan

Looking at this again, it's clear to me now that the second comment is incorrect. Since that's taken care of by the admin classes and this is all happening at...

The second paragraph being incorrect doesn't change anything about the first. It's a feature request ticket. You can handle it as you like, of course. If you would like to...

Only the fields mentioned as keys in `entangled_fields` are initialized, but my situation is that some of the JSON keys are unknown - the values in `entangled_fields`. So when we...

@fsbraun explained it better than I did! If you get a chance to make those changes, I'll take a look and see if I can switch over in my application....

Oh it's an open source project. So, I do that kind of thing with (in my case) AdminJSONForm, eg, [here](https://github.com/johncronan/formative/blob/17adb8138ec6da7dcc0882739bfae3fa43b86fd3/formative/forms/admin.py#L336) and [here](https://github.com/johncronan/formative/blob/17adb8138ec6da7dcc0882739bfae3fa43b86fd3/formative/forms/admin.py#L406). That's a good idea, and it hadn't occurred...

I tried to implement a subclass of DynamicArrayWidget for the case where the subwidget is forms.Select: ``` class DynamicArraySelectWidget(DynamicArrayWidget): def __init__(self, *args, **kwargs): kwargs['subwidget_form'] = forms.Select super().__init__(*args, **kwargs) def get_context(self,...

> I wrote an app where (potentially) users can customize the fields of a model where all fields are stored in a polymorphic model. > The aim of the project...

It looks like in [this spot](https://github.com/django-polymorphic/django-polymorphic/blob/bd5faf0c829f87dc6fcc42c6bfbb689d665a5bf4/polymorphic/models.py#L212) ``` def create_accessor_function_for_model(model, accessor_name): def accessor_function(self): objects = getattr(model, "_base_objects", model.objects) attr = objects.get(pk=self.pk) return attr return accessor_function subclasses_and_superclasses_accessors = self._get_inheritance_relation_fields_and_models() for name, model...

@vdboor, what do you think? I wonder if you could assist me with the implications part, and what a good fix ought to look like? I've been planning to implement...

https://github.com/django-polymorphic/django-polymorphic/commit/544f5edef4b1f1cc879018bdd7f205b9082b122a > At this point, we don't know why this line of code is executed, but we do know it's not consistently executed between Django 1.10 and Django 1.11 due...