parceler icon indicating copy to clipboard operation
parceler copied to clipboard

Build log full of keep entry IdentityCollection

Open fchristysen opened this issue 7 years ago • 2 comments

I used parceler version '1.1.6' with proguard enabled. I have these proguard rules in my 'proguard-rules.pro' : -keep interface org.parceler.Parcel -keep @org.parceler.Parcel class * { *; } -keep class **$$Parcelable { *; } When I build the apk using terminal (or happen too with my Bitrise CI), the terminal output full of Note: the configuration keeps the entry point 'someClass$$Parcelable { void write(someClass,android.os.Parcel,int,org.parceler.IdentityCollection); }', but not the descriptor class 'org.parceler.IdentityCollection'" logs. someClass represents class in my project that implement parceler.

This log cause a problem in my CI, since the log file becomes too big(2.2 MB), and cause the build to fail. I have to add another proguard rules "-keep class org.parceler.IdentityCollection", to make this notes disappear.

My question is, what is this IdentityCollection? and will it cause a problem if I keep the IdentityCollection class?

fchristysen avatar Mar 05 '18 03:03 fchristysen

IdentityCollection is used to compare and determine uniqueness in a graph of objects during deserialization. Adding the proguard rule you mentioned is a good idea.

johncarl81 avatar Mar 05 '18 16:03 johncarl81

Should we add this to the suggested proguard configuration?

johncarl81 avatar Mar 06 '18 19:03 johncarl81