query-monitor
query-monitor copied to clipboard
johnbillion
Inline scripts and styles
Could you mark localized scripts (data) and inline styles (extra) in Scripts and Styles?
I've been working on implementing this, and I'm getting close:
but can't determine the best way to handle large amounts of inline data:
@johnbillion do you think simply limiting the output to a certain number of characters is a decent solution?
I'm wondering, if it's even worth it to show the inline data... it's in the source of the page, so perhaps just indicating that there is inline data is sufficient (as if you're interested, you could go look find it in the source)?
hmmm yeah I think providing the first 60 characters or so would be enough; user could grab the characters and search for them in the source. will do that.
I'm wondering, if it's even worth it to show the inline data...
Yes, my issue was: "Could you mark ..."
yeah, that's what got me thinking about even showing it... I do and don't like showing it; seems redundant, but also helpful for a quick glance. thinking it over
@szepeviktor count how many items are in the data and after keys? data is only a string, but after can have multiple items... is that what you're wanting? a count of how many inline scripts have been added?
@johnbillion Is there something in particular you're wanting to do with this, that kept it from going through in 2016? Please let me know; happy to do what needs to be done to get this into QM core.
I think I decided that I wanted to expose more information than this, or in a better way, but I ended up having decision paralysis. I'll check out your updated PR, thanks.