Pre-release milestones

[johnbillion]

Does Probot semver need to handle pre-release milestones and releases? For example, betas.

[gr2m]

Can you explain your thinking behind the pre-release milestones? I use semantic-release on all my node projects and I think it's a cool idea that if there is a milestone with the same name it gets closed, but usually I only use that for major release numbers, not for minor or patches.

As an example see https://github.com/octokit/node-github, I'm have a pending pull request for the next major version to release multiple breaking changes at once. It'd be cool if a github app would close the according milestone automagically, but I don't need the pre-release milestones

[johnbillion]

Currently, Probot semver extracts the version number from the release tag (which allows for tags such as v1.2.3) and then looks for a milestone with that exact version number (1.2.3). It only allows an optional prefix, not a suffix, because otherwise if a project pushed a 1.2.4-beta1 release then it would close the 1.2.4 milestone.

I opened this ticket to decide whether or not beta milestones should be handled (are they common?).

I just took a look at https://github.com/octokit/node-github and I saw that you're using milestones with a suffix, such as v13.0.0 - Maintainability. Probot semver won't automatically close this when you push the v13.0.0 release because it currently only supports milestones which use the exact version number extracted from the release tag name (13.0.0).