probot-semver icon indicating copy to clipboard operation
probot-semver copied to clipboard

Decide how to handle earlier, unreleased milestones

Open johnbillion opened this issue 8 years ago • 2 comments

When my project is on version 1.1.0 and I release 1.2.0, should the 1.1.1 milestone also be closed? Is it safe to assume that for most projects the previous major and minor branches won't be maintained? Is it possible to make this an option in the app?

johnbillion avatar Oct 28 '17 02:10 johnbillion

Looks like other Probot apps read from a Yaml config file within .github.

johnbillion avatar Oct 28 '17 02:10 johnbillion

If Probot semver chooses not to close any milestones other than the one which was just released (as it currently does), the repo maintainer still has to manually close the patch branch for the previous minor, and the minor branch for the previous major, as relevant. Not ideal.

Possible config options:

  • Major release closes earlier minor milestones: When releasing a major version, close all earlier minor milestones. y/n.
  • Major release closes earlier patch milestones: When releasing a major version, close all earlier patch milestones. y/n.
  • Minor release closes earlier patch milestones: When releasing a minor version, close all earlier patch milestones. y/n.

Needs some nice handling for when earlier milestones due to be closed still have open issues.

johnbillion avatar Oct 28 '17 09:10 johnbillion