render-deploy-action icon indicating copy to clipboard operation
render-deploy-action copied to clipboard

Error responses fail job and provide a bit more output

Open DylanFM opened this issue 3 years ago • 3 comments

When error responses are received from the Render API it doesn't fail the job. I noticed this when encountering a 401 error upon first getting this setup. So this uses Response.ok to check if the response is successful, otherwise fails the job.

Also, I have been wanting a bit more output showing what Render responds with when triggering a deploy. Not 100% sure what's best for the output here, but the this should be a bit more useful.

e.g

Run dylanfm/render-deploy-action@status-fails
Deploy build_in_progress - Commit: Revert "Reference with sha"

This reverts commit 56d02be7aece6e5d050c3240abeb0be0e41e79ea.

DylanFM avatar Apr 26 '22 22:04 DylanFM

@DylanFM mind to fix the conflicts? This fix would be appreciated!

MorenoMdz avatar Jun 06 '23 01:06 MorenoMdz

Hi @MorenoMdz. Does the update @johnbeynon made in 4545b7c4803158c6ce195c86a8efeee77d11d256 cover your needs? This PR may be OK to close.

DylanFM avatar Jun 06 '23 14:06 DylanFM

For me it still shows success in the job even when it 401.

MorenoMdz avatar Jun 06 '23 16:06 MorenoMdz