Jonathan Hao

Results 30 comments of Jonathan Hao

The app has been deployed. I realised I haven't updated the URL path http://ci.aztec-labs.com/breakdown-viewer. It will be in the follow-up.

I ran the ClangStaticAnalyzer but it only finds bugs in this `mdb.c` which I think is just some dependency. Is it because most of our compilation is cached and I...

I also tried `scan-build ninja clean` beforehand to make sure it's a clean build before `scan-build ninja`.

I have got some partial `cppchecker` results as well in https://docs.google.com/document/d/1Qs6ZPYuySVcdu-x0TPI1AF4HeiSlOlVSGi3KqtuuJw0/edit?usp=sharing

I was able to run ClangStaticAnalyzer with CodeChecker instead. Here are the reports https://drive.google.com/drive/folders/1Xpr52o6yC7CvEqDu5HB0tBPG4VGf1XJ_?usp=sharing. I'll go through them and get a feeling of the false-positive rate.

Here is the report from pvs-studio in a [spreadsheet](https://docs.google.com/spreadsheets/d/1iUF8STrPEi6xRVgSL7RTCpDPANpRqsZV5t45NrQnhHA/edit?gid=224955441#gid=224955441). There are also [htmls](https://drive.google.com/drive/folders/1l6orgpmUjXXb1yd22iuNNCPa40fD0qzC?usp=sharing) to visualize them better.

https://github.com/AztecProtocol/barretenberg/issues/1591 could introduce some breaking changes, such as defaulting to solidity.

This is currently on hold due to security considerations.

Judging from the "Iterations" field, these cannot be reproduced reliably, can they? Then, we can only guess what to fix based on the stack traces?

Although I guess if we have a potential fix, we can run the same iterations again and again and see if the same errors appear. What is run in each...