John O'Hara comments

Results 92 comments of


                                            John O'Hara

Orphaned Fingerprint Labels on Change Detection when a Schema is deleted.

I don't think we should spend time investigating this if we are going to remove schemas

Labels names are considered semantically equivalent throughout the entire system

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

Deleting Schema does not remove schema from UI list

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

Display transformer warning in datasets without a schema

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

Pagination for AllSchema.tsx should allow sorting by multiple fields, not just name

That is the default for the UI, and it is possible to sort by other columns, but if a user selects a different column to sort by, the sorting is...

Pagination for AllSchema.tsx should allow sorting by multiple fields, not just name

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

Schema list returns count of all schemas, regardless of visibilty

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

Schema update transactions timeout

`flush` does not commit the TX. the TX is committed when the `public Integer add(Schema schemaDTO)` method returns. within this method, there are calls to `mediator.newOrUpdatedSchema(schema)` which process all runs...

Schema update transactions timeout

> So we should require a new tx for processing the runs. Then again, this should be refactored into two methods, one add and one update as it does different...

Schema update transactions timeout

> I think we should refactor out the update logic and create a separate api call for update. The update method could then return some info we get from the...