TVHGuide icon indicating copy to clipboard operation
TVHGuide copied to clipboard

Features, merge possible?

Open MrFly opened this issue 11 years ago • 43 comments

Hi @john-tornblom,

first of all: thank you for this great app, this saved many times my day :-)

I downloaded the sources of TVHGuide two or three days ago and added some (useful?) features and I wanted to ask you if you eventually would merge this to your branch. I would like to have a way to contact you directly with a little more privacy. Do you see a way and have a little time to chat a little about this? I'm sorry, but due to the lack of sending mails over github (or I simply didn't find a way) I opened this ticket...

Regards, Johann

MrFly avatar Dec 09 '13 10:12 MrFly

Hi Johann, what features did you include? Did you check out my branch? (https://github.com/rsiebert/TVHGuide) It contains more features and an improved UI than this one. Unfortunately my branch is also not merged. See the screenshots at https://github.com/rsiebert/TVHGuide

rsiebert avatar Dec 13 '13 09:12 rsiebert

Sorry for being idle, i'm very busy these days and have little time over for TVHGuide. Once I get some time over I'll see if I can integrate some new features.

john-tornblom avatar Dec 13 '13 17:12 john-tornblom

Hi Rsiebert DId you check you version app TVHguide why cant play stream tv from TVHeadend. I describe you this problem in other issue. When i want play TV i have error.

Please update polish language in you app from this https://github.com/PiterEL/TVHGuide/commit/6a98632fd5074786bde7e938a2c330145a589309

ghost avatar Dec 15 '13 19:12 ghost

I fixed this in my local repository. I'm currently working on a program guide view. When its done I'll release a new version.

rsiebert avatar Jan 08 '14 10:01 rsiebert

Ok i am wait for info :) Please tell me on this thread.

ghost avatar Jan 08 '14 10:01 ghost

@PiterEL I have released the new version 1.9.0. It contains some fixes and a new program guide. You can download it at http://rsiebert.github.io/TVHGuide/

rsiebert avatar Jan 31 '14 15:01 rsiebert

Ok i download And install your version 1.9.0 and still i have problem with play tv. I have error open file xxxxx(numbers). I use external player name BSplayer.

ghost avatar Jan 31 '14 16:01 ghost

Did you play with the available settings? For the media container use matroska, external player must be checked :-), transcode stream not checked. What error is shown? But the rest is working ok?

rsiebert avatar Feb 03 '14 10:02 rsiebert

OK works. But it working after setting the IP address tvheadend in Settings> Section Playback> Programs. There is also the Host Name section. Although CONNECTIONS I added the IP address of the server from TVHEADEND. Why is typing the host names in the joints and in the SETTINGS?

Is you app 1.9.0 can we download from Google Play Store in future ? It is very very good apps. Better than original TVHguide which we can donwload now from google play.

ghost avatar Feb 03 '14 12:02 ghost

Good to hear that it works. I'll remove the host settings and use the one from the connection. Makes indeed more sense.

rsiebert avatar Feb 03 '14 12:02 rsiebert

When did you relased new version with no host name in setting ?

ghost avatar Feb 03 '14 12:02 ghost

In STATUS when i recorded the programm i have a info: PROGRAM %S JEST NAGRYWANY... This is bug.... WHAT can display instead of %S ? My suggest is to add to SETTINGS opction to set language... not default set which is android language.

Update today my Polish translateed i send pull request.

ghost avatar Feb 03 '14 12:02 ghost

Thx for noticing the bug and updating the translation! I have fixed this and included your new translations. I'll make a new app version tomorrow.

rsiebert avatar Feb 03 '14 16:02 rsiebert

Why you apps is not published in Google Play ?

My suggest is to add to SETTINGS opction to set language... not default set which is android language.

Can you describe me how i can make from source apk to android ?

ghost avatar Feb 03 '14 17:02 ghost

Only he original author can publish an app under the name TVHGuide. So I need to use a different name like TVHGuide. I'll probably go for it. I'll look into the language setting. I'll use eclipse to develop and create a signed application. Just google "eclipse create signed android application" or something similar.

rsiebert avatar Feb 03 '14 18:02 rsiebert

I'll look into the language setting

I think about in menu the user can set language what you want.

ghost avatar Feb 03 '14 19:02 ghost

@PiterEL New version 1.9.1 is out

  • I have added the language selection in the settings menu.
  • The %S bug should be gone.
  • The server from the connection is now used for playback

There are some new strings to translate to polish. I guess its better you make a pull request against my repository not this one. You can also raise issues or features in my project so I can track them better.

rsiebert avatar Feb 04 '14 15:02 rsiebert

Hello I installed version 1.9.1 and i see that you did not update some translation in polish...

ghost avatar Feb 04 '14 16:02 ghost

Hi, I have used the translation from #4. Maybe I missed something. But there are two more strings like pref_language ... to translate. If you make a PR then I'll add it.

rsiebert avatar Feb 04 '14 18:02 rsiebert

I will done this new translation today or tomorrow...

ghost avatar Feb 04 '14 18:02 ghost

Can i add Pull request to your git or git john...?

ghost avatar Feb 04 '14 18:02 ghost

Hi, its better to do it against my git project.

rsiebert avatar Feb 04 '14 20:02 rsiebert

OK i update translated to polish from english 1.9.1 It ist newest polish translated. You add this to you apps.

https://github.com/rsiebert/TVHGuide/pull/8

Change the file strings.xml to Polish language. I made the analogy to the English.

Add also https://github.com/rsiebert/TVHGuide/pull/7

When did you plan add this fix translated and released new version with new number ?

ghost avatar Feb 04 '14 21:02 ghost

When did you release version with my fix ?

ghost avatar Feb 05 '14 14:02 ghost

Hello Rsiebert. Can you help me how i can buil apk for android from git ? I download and install Android SDK and Java JDE. After that i download on my local disk files from github. My folder with TVHGuide is location C:\Users\Piotrek\Documents\GitHub\TVHGuide

I open ECLIPS editor and import source from Git and then select local and select directory C:\Users\Piotrek\Documents\GitHub\TVHGuide

After i double clic on Android Manifest and select Export an unsigned APK and sign it manually

ANnd i have a problem error. Can you help me with this ?

Failed to export application Command-line Error 1 Output: C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values-de\strings.xml:39: error: Resource entry delete_connection is already defined. C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values-de\strings.xml:38: Originally defined here. C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values\styles.xml:80: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat'. C:\Users\Piotrek\Documents\GitHub\TVHGuide\bin\res\values\styles.xml:107: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.Light'.

ghost avatar Feb 05 '14 21:02 ghost

@PiterEL I have released the new version.

rsiebert avatar Feb 07 '14 12:02 rsiebert

Can you Tell me how i can build apk on my computer. Please...

ghost avatar Feb 07 '14 12:02 ghost

You need to import the following two projects into eclipse

  • https://github.com/kolavar/android-support-v4-preferencefragment
  • and also the android-support-v4-appcompat library. (it should be under \extras\android\support\v7\appcompat

then add these two project to TVHGuide by going to "right click on TVHGuide -> properties -> android -> add library

rsiebert avatar Feb 07 '14 14:02 rsiebert

Where i can found seceond project ? In android SDK ?

First i know that import > git

ghost avatar Feb 07 '14 15:02 ghost

where your SDK is installed. Maybe C:\Programs\adt-bundle\sdk\extras\android\support\v7\appcompat or C:\Programs\android\sdk\extras\android\support\v7\appcompat

rsiebert avatar Feb 07 '14 16:02 rsiebert