John Parton comments

Results 163 comments of


                                            John Parton

max_extrude_cross_section error

I just got this error, and I changed the "Maximum path deviation" / "Resolution" setting in Cura from the default 0.05 to 0.02 and it worked. I guess it's probably...

max_extrude_cross_section error

I lie. It got part way into the print and failed half way through. Do you want me to upload an STL and the Cura settings I used?

Bugfix/mips32 dynarec

I've got no clue. I barely remember what I coded last month versus 16 months ago. 28 months. Yeah, no idea.

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

I've updated the PR. I fixed the linter errors and put the test in the correct module and removed my fixtured, using the existing image fixtures.

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

I'll resolve the failing test. I believe I understand what's going on.

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

I made some additional changes which means my change touches fewer internals. It's very narrow in scope and shouldn't effect backwards compatibility, except in one specific case: Prior to this...

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

@felixxm Can I get a review of this? I think it does **exactly** what it's supposed to do: no more, no less.

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

No problem. I was chatting with him on Discord, but I understand the etiquette

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

Thanks, this is really great info! I'll get the linter issue fixed. I did add some docs with my last push.

Fix #8307 -- Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation

I've pushed the linter fix. Let me know if there's anything else I need to do.