Johan Ljunggren
Johan Ljunggren
At this line the module PowerShellGet is imported to verify version. https://github.com/gaelcolas/Sampler/blob/d19ef072498ac9df81a3839b0b7a502a066f2235/Resolve-Dependency.ps1#L233 But we already imported it at line: https://github.com/gaelcolas/Sampler/blob/d19ef072498ac9df81a3839b0b7a502a066f2235/Resolve-Dependency.ps1#L171 We should be able to reuse the variable at line...
It is indicated that build.ps1 loades aliases that it should not (see the line with `Set-SamplerTaskVariable`). ``` Importing tasks from module Sampler Loading Build-Module.ModuleBuilder.build.Sampler.ib.tasks... Loading ChocolateyPackage.build.Sampler.ib.tasks... Loading Clean.ModuleBuilder.build.Sampler.ib.tasks... Loading DeployAll.PSDeploy.build.Sampler.ib.tasks......
### Problem description When merging code coverage from several jobs the task to download pipeline artifacts must specify individual destination folder. This in necessary if each test job is generating...
It'd be good to also add 'UseCodeCovIo' as an option in `${PLASTER_PARAM_Features}`. It's not blocking though. _Originally posted by @gaelcolas in https://github.com/gaelcolas/Sampler/pull/325#discussion_r706832915_
### Problem description It is possible to not add configuration files for GitVersion when creating a module using the templates. But if GitVersion is installed it will be used regardless....
> I wonder if it's a good decision to remove the PSSA rules and vscode integration. > It's ok to not enforce them, but I'd prefer that we still "highlight"...
### Problem description When using the template _dsccommunity_ the build.yaml that is generated does not contain the key `MainGitBranch` under the key `DscTest`. ```yaml DscTest: MainGitBranch: main ``` ### Verbose...
### Problem description We have always used the following indentation style for pipelines in DSC Community repositories (HQRM modules). ``` "powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationForFirstPipeline", ``` but currently the template is set to...
We should also create issues for the guideline for class-based specific rules that are missing.
We should move and update the test templates from here https://github.com/PowerShell/DscResource.Template/tree/master/Tests to this repo. For example the integration tests are missing in this repo.