Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Stories flag enabled by default in internal preferences, that doesn't work

Open pixincreate opened this issue 3 years ago • 2 comments

  • [x] I have searched open and closed issues for duplicates
  • [x] I am submitting a bug report for existing functionality that does not work as intended
  • [x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
  • [x] This isn't a feature request or a discussion topic

Bug description

Title says it all. Internal preferences have have stories enabled by default. However, on checking logs, it showing the status flag as falsewhich I believe is wrong.

Either you unknowingly enabled stories option or it doesn't work as intended.

Steps to reproduce

  • install Signal JW version
  • Check internal preferences, stories us enabled by default
  • however, that option isn't visible

Actual result: stories not flag is disabled Expected result: stores option should be visible

Screenshots

Device info

Device: Android Android version: 12L Signal version: 5.45.2

Link to debug log

pixincreate avatar Aug 05 '22 16:08 pixincreate

AFAIK this option in internal settings is used to disable stories, even if they become active. The actual active / inactive is determined by Featureflags.java line 455, which defaults to false but can remotely be set to true. I don't try to activate them in my fork by changing the code here.

johanw666 avatar Aug 05 '22 17:08 johanw666

option in internal settings is used to disable stories,

This option already exist by default for Signal once stories option is enabled. I saw that in Signal community feature request forum.

So, I don't think that option that currently exist would be useful for anything and instead, it can be used to enable/disable the actual stories that exist in line 455.

pixincreate avatar Aug 06 '22 04:08 pixincreate