Johan Vos

I believe both @kevinrushforth and @nlisker have correct and relevant points. I believe the "different discussion" as mentioned by Nir is actually the first discussion though. We currently have a...

> If the build.gradle can be broken up even more (based on the functionalities) it could help making heads and tails of it. > As for where to put the...

There are 2 open issues with this PR (actually 3, as it needs to have a corresponding JBS issue but that is easily solved) * the changes related to the...

Thanks for the PR! Quick observations: * The unit test is indeed clear and at first sight, it looks to me that this is reasonable behavior. One of the hard...

> 1. With variable height cells: if I click below the scrollbar thumb, followed by a click above the thumb, I expect the view to go back to the same...

@FlorianKirmaier I still think this would be a good addition. I believe there is only one open question (from Marius) so it would be great if you can answer that.

I plan to do an in-depth review later this week.

Intuitively, the added test seems to be the right thing to do. It indeed fails before and succeeds after the patch. However, I'm not sure about the implementation. The suggested...

That's a good question. Since there are a number of scenario's that change the current position (offset) of the VirtualFlow, we have to be careful that those scenario's are not...

> I did a build with GTK 3.22 (so it compiles the new code, does the dlsym, and does the runtime check) and verified that there are no regressions when...