Johan Vos

Results 112 comments of Johan Vos

As for the testing issue: the memoryleak before this fix leads to an increasing number of `com.sun.glass.ui.MenuItem` instances. We could test the previous memoryleak, as that was creating an increasing...

Moving this to [WIP] while I'm working on automated tests.

@hjohn You're absolutely right. It's another reason why I moved this PR to [WIP]. Instead of guessing and trying, I want to understand the deterministic path that leads to the...

As for the memory leak issue: there were several. The first commit in this PR fixed a clear memory leak, but the one that is still left is not described...

Thanks @hjohn for the clear explanation. I replaced the Weak listeners with the new listener resource management approach, and that works fine. I'm still looking into adding a test. The...

I added a systemtest using a new Shim (`GlassSystemMenuShim`) that keeps track of the `com.sun.glass.ui.Menu` instances that are created in the `GlassSystemMenu`. I had to do a few more hacks...

A few things about the latest commit: 1. The usage of the `active` property caused regression: the memoryLeak test that was introduced in the fix for JDK-8318841 now failed. A...

@FlorianKirmaier Thanks for the additional test. There was already a test in the SystemMenuBarTest, but it's really good to have an additional test for this -- I added it.

@kevinrushforth thanks for the feedback. I merged master and I see the failing test on Linux now as well. That is very interesting. I'll investigate and fix, and address the...