kirbyup icon indicating copy to clipboard operation
kirbyup copied to clipboard

feat!: migrate to Vue 3 & remove deprecated options

Open johannschopplich opened this issue 10 months ago • 6 comments

Work in progress.

johannschopplich avatar Apr 22 '24 07:04 johannschopplich

Deploy Preview for kirbyup ready!

Name Link
Latest commit 8c8a728bcf8150c4438f7ef2378ab5ce72049ee3
Latest deploy log https://app.netlify.com/sites/kirbyup/deploys/66e143eb69021800087c8787
Deploy Preview https://deploy-preview-45--kirbyup.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 22 '24 07:04 netlify[bot]

@jonaskuske Hi there! The Kirby team (especially @distantnative) is working on the Vue 3 Panel update. Once it's ready and testable, would you please help in updating the HMR support? Much appreciated. 🙂

johannschopplich avatar Apr 22 '24 07:04 johannschopplich

Yes, will do :)

jonaskuske avatar Apr 22 '24 08:04 jonaskuske

@johannschopplich @distantnative

What's the right place to discuss Vue 3 migration plans? There are some aspects that directly affect HMR compat:

  • In Vue 2, Kirby externally modified/overwrote Vue component options. These modifications would get lost when Vue replaced the component instance with a fresh, updated component definition, so kirbyup-specific modifications of the HMR runtime were necessary. If component modification/extension could be handled differently for Vue 3, that would greatly simplify HMR support and limit edge cases
  • In Vue 2, the HMR runtime code was supplied through @vite/plugin-vue2, so it shipped with kirbyup. In Vue 3, the HMR runtime code is part of the main (development) Vue build. So Kirby would need to include both the production and the development build of Vue, and serve the dev build when kirbyup development is detected (index.dev.mjs exists, Kirby already checks for this)

jonaskuske avatar Apr 22 '24 08:04 jonaskuske

Good points, @jonaskuske!

In my opinion a separate thread or better a DM group would be appropriate. We could also talk in German when we're there. 😜

johannschopplich avatar Apr 22 '24 08:04 johannschopplich

Wanted to start a Discord chat, but @jonaskuske first has to accept my friend request :D

distantnative avatar Apr 23 '24 10:04 distantnative