super-productivity icon indicating copy to clipboard operation
super-productivity copied to clipboard

Webdav sync sync username and overwrites in a multi-device/user setup

Open lerra opened this issue 2 years ago • 5 comments

Your Environment

Ubuntu 22.04 / Linux and latest version of the snap package two android devices running android 12 and latest version of the app Syncing towards a webdav server with separate usernames

Expected Behavior

Syncing between should work and not touch username fields for sync, sync settings should be local settings.

Current Behavior

When having user1,user2,user3 setup using webdav, username is included in the superproductivity json file and is loaded into superproductivity and overwrites the username value

Steps to Reproduce (for bugs)

  1. User1 syncs the file to webdav server
  2. user2/3 syncs the file, user 2/3 gets the username1 value overwriten in sync settings (but not the password).
  3. User2/3 syncs but gets an error from webdav server because the user1 have the wrong password.

Can you reproduce this reliably?

Yes

Console Output

No

lerra avatar Sep 10 '22 19:09 lerra

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] avatar Sep 10 '22 19:09 github-actions[bot]

Hello there lerra! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

github-actions[bot] avatar Sep 10 '22 19:09 github-actions[bot]

Not sure this is a bug, since the app is intended to be used by the same user. I agree however that it would be better for these settings not be synced.

johannesjo avatar Sep 14 '22 14:09 johannesjo

To give some background, it is the same user but i have device accounts with different access in webdav but if that is the case and it will not get fixed I will create a separate account only for super productivity. As long as I know what you decide:)

It's been an annoying problem for three months that i finally figured out the root cause:)

Big thanks for the project you built!

On Wed, Sep 14, 2022, 16:37 Johannes Millan @.***> wrote:

Not sure this is a bug, since the app is intended to be used by the same user. I agree however that it would be better for these settings not be synced.

— Reply to this email directly, view it on GitHub https://github.com/johannesjo/super-productivity/issues/2238#issuecomment-1246866103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJZPFWEZ6CL22ETQP3IYV3V6HPKZANCNFSM6AAAAAAQJOXF34 . You are receiving this because you authored the thread.Message ID: @.***>

lerra avatar Sep 14 '22 14:09 lerra

To be honest: I likely won't work on this myself anytime soon. But in case someone comes along with a PR, I promise to review and merge it as quickly as I can.

johannesjo avatar Sep 16 '22 12:09 johannesjo

This issue has not received any updates in 90 days. Please comment, if this still relevant!

github-actions[bot] avatar Jan 15 '23 02:01 github-actions[bot]