super-productivity icon indicating copy to clipboard operation
super-productivity copied to clipboard

Windows Tray Icon stays black

Open halloichbingunnar opened this issue 3 years ago • 8 comments

Super Productivity 6.5.2 on Windows 10

Super Productivity tray icon is black on black (and doesn't change even if I change Windows to dark mode): Screenshot 2021-04-01 104858

I just learned today that it should look different, though. Is there anything in the settings that I may have missed or is this a bug? :)

halloichbingunnar avatar Apr 01 '21 09:04 halloichbingunnar

Hi there! Thanks for reporting this! This is a bug and might be a good issue for people being new to the project.

johannesjo avatar Apr 02 '21 19:04 johannesjo

In the code, the variable shoudUseDarkColors in the indicator.ts file is equals to: forceDarkTray || nativeTheme.shouldUseDarkColors.

First, at least in Linux, the forceDarkTray, in main.ts, is never changed because the val in process.argv.forEach((val) => {..} never includes '--force-dark-tray'

Second, the shouldUseDarkColors not exist in the nativeTheme. The nativeTheme only contains the keys: _events, _eventsCount ad _maxListeners.

To make it use the light version of the tray icon I had to manually change the shouldUseDarkColors to true

I don't know how to solve it, so I cannot make a fix and a merge request, but If it would be more complicated then it seems, a simple temporary solution will be to make a icon with a blue circle background, like the logo.

DenysMb avatar Apr 15 '21 21:04 DenysMb

Hey there! I just updated the electron version to 12. Not sure, but this might fix the issue for windows, even though I didn't find anything in the changelogs.

It's also possible to work around this issue by adding the --force-dark-tray flag when starting the app, but that is not very user friendly I have to admit.

johannesjo avatar Apr 16 '21 11:04 johannesjo

In gnome the white version should be default no matter the theme, because the top bar is always dark.

With the Adwaita-dark theme it shows the correct icon.

This is with the default gnome theme (you can only see it when you hover over it):

superprod_gnome

To be fair you have to install an extension to see the icon tray in the first place.

schlauerlauer avatar May 20 '21 06:05 schlauerlauer

This issue has not received any updates in 90 days. Please comment, if this still relevant!

github-actions[bot] avatar Sep 18 '21 01:09 github-actions[bot]

This is still relevant. I was about to create a new issue

image

@johannesjo, could you reopen this issue, please?


Your Environment

  • Version used: 7.10.1
  • Operating System and version: Windows 10.0.19042 Build 19042

Installed via winget.

Expected Behavior

Tray icon should be white to be visible in the tray against the black background of the taskbar.

Current Behavior

Tray icon is black leading to low visibility.

trallnag avatar Mar 08 '22 11:03 trallnag

This issue has not received any updates in 90 days. Please comment, if this still relevant!

github-actions[bot] avatar Jul 21 '22 02:07 github-actions[bot]

The issue is still there.

rklec avatar Jul 21 '22 19:07 rklec

I would like to take on this.

zoli avatar Aug 19 '22 06:08 zoli

After checking the code, I think the problem is OS specific even OS version specific for windows. What I found in linux systems for at least i3 (which I use myself), Gnome, Ubuntu the problem is that the status bar background is dark no matter the theme is light or dark, So I think the default should be to use dark colors (tray icon with white color) for those. I don't use windows but from what I have seen in youtube for windows 11 the code works fine because the taskbar background color changes regarding to system theme, but for windows 10 (as @halloichbingunnar pointed) the taskbar is always dark and it should be same as linux I think. Also for mac which I don't use either, I think the code works fine and there is no need to any change.

So my suggestion would be to change set shouldUseDarkColors to true for windows 10 and linux systems.

If its OK by you @johannesjo I will go and create a PR for it.

zoli avatar Aug 25 '22 06:08 zoli

@zoli ! Makes sense to me! Thank you!

johannesjo avatar Aug 26 '22 09:08 johannesjo