Johannes Coetzee
Johannes Coetzee
The changes in this PR seem to achieve the goal they intend to, but this was actually the way it was done in the `TypeInferencePass` in the past and we...
@fabsx00 and @DavidBakerEffendi I think it would be good to have another discussion about type inference in javasrc2cpg. We've run into a couple of situations where legitimate bugs were hidden...
@DavidBakerEffendi @khemrajrathore An off-by-default flag would work, although in my opinion this would be a temporary measure until we reach a decision on how to handle inference in general. As...
If we go for this approach, then I'll add a comment to open PRs pointing them at this issue for the guide on how to update PRs
I've opened https://github.com/javaparser/javaparser/pull/4409 as a PR for step 1 of the reformatting process. It's fine if there end up being some commits merged between this one (assuming it's accepted, of...
An idea I had from https://github.com/javaparser/javaparser/pull/4414 is that, if automatic reformatting is supported, we could probably add a CI workflow to run the code generators, reformat the code, and fail...
Of course! I understand that this would have a major impact on the codebase and is not a decision to be taken lightly. If, at any point, you have any...
I've updated the initial spotless PR to remove the section that's not related to formatting java source code since on second thought I think this change is big enough already....
I've opened https://github.com/javaparser/javaparser/pull/4465 for the actual formatting change
I've opened https://github.com/javaparser/javaparser/pull/4466/files for ignoring the reformat in git blame. The last thing I want to add for this is a github action step to verify that the code has...