Johann du Toit

Results 18 comments of Johann du Toit

I saw the PR already got closed, so just linking here to my comment on the PR about remaining performance issues @dessalines and @Nutomic : https://github.com/LemmyNet/lemmy/pull/2952#discussion_r1223796997

I've been helping Ruud look at this a bit @Nutomic, and I'm starting to think it's not db. If you post, and then in another window refresh the comments, the...

> ### paging is unstable > Paging in the database is unstable. For example: We fetch 100 comments, ordered by hot ranking. The user reads those comments and scrolls on....

> This is not so much an issue for Posts. But it is for comments. Ah okay! I was thinking of posts, yes. You're right.

Broken for me too - the issue seems to be the alpine version: https://www.bountysource.com/issues/71091841-build-error-with-alpine-3-9 I changed `alpine:latest` to `alpine:3.8` at the top of the Docker file and `make install` started...

@jtwang you should see our hackish workaround! Monkey patching get_date_format in the library with a partial to always return the format we want. :)

Thanks @akx. So if we aim for 3.0 should the PR just be against master?

I'd just like to report back that we've been using the `grouped_bars` function from this notebook for more than 6 months in production without a single issue ever coming up....