Johan Malm
Johan Malm
@droc12345 fancy reviewing/testing this approach and giving me some feedback?
> I didn't check any Xwayland stuff as I run strictly wayland, X not even installed. Same applies to mousepad with about dialog open on wayland
Well... ready for review I think. There isn't much left of `desktop_cycle_view()` which is normally a good sign. I suggest we leave the addition of `rc.cycle_view_criteria` (or whatever) for another...
In order to get this merged, could we leave the workspace considerations until later (unless there is something we ought change in this PR to lay the foundations). For me...
> Another thing I noticed with this PR is that there are still some occurrences of `server->workspace_current->tree->children` in `src/osd.c`. Those should likely be removed / replaced in lockstep with the...
I think I've responded to all review comments thus far, except possibly the inclusion of `` (or whatever) to show dialogs - i.e. to `&= ~LAB_VIEW_CRITERIA_ROOT_TOPLEVEL`) if we still want...
@jp7677 With you knowledge of the tablet cursor-emulation, would you have the capacity/time to review this patch?
LGTM. Can't test, but code looks good. Nice addition.
-- EDIT -- Will keep updating this as the thinking develops. Okay, I think we've got a few things to research and get right with layer-shell surfaces. It'll probably be...
> As well as this: https://gitlab.freedesktop.org/wlroots/wlr-protocols/-/blob/master/unstable/wlr-layer-shell-unstable-v1.xml?ref_type=heads#L275 Good spot. That links says "This setting is inherited by child surfaces set by the get_popup request." I read that as the client should...