matchbox icon indicating copy to clipboard operation
matchbox copied to clipboard

Handle returning to ice gathering stage

Open johanhelsing opened this issue 1 year ago • 5 comments

Currently we stop anything related to ice once the data channel has opened, however It's possible to return to the ice gathering state, and we should probably handle that.

Ref this comment: https://github.com/johanhelsing/matchbox/blob/97c2ea1ed5dfbfd2f987af661973e28ed6e47f47/matchbox_socket/src/webrtc_socket/wasm/message_loop.rs#L255

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/iceGatheringState

johanhelsing avatar Jan 12 '23 09:01 johanhelsing

Is this only for WASM?

simbleau avatar Feb 20 '23 01:02 simbleau

I don't know/remember. Not really sure exactly what kinds of things will trigger additional gathering either.

Perhaps if you enable or disable wireless?

I wrote this down mostly because i saw it in the mdn docs and didn't want to forget about it.

johanhelsing avatar Feb 20 '23 16:02 johanhelsing

relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Session_lifetime#ice_restart

johanhelsing avatar Feb 24 '23 15:02 johanhelsing

This sounds low priority since it is a network renegotiation under rare circumstances to increase performance, not to solve a severe problem in connectivity.

Good find.

simbleau avatar Feb 24 '23 15:02 simbleau

Yes, let's ignore it for now, we have bigger fishes to fry :)

johanhelsing avatar Feb 24 '23 15:02 johanhelsing