bevy_pkv icon indicating copy to clipboard operation
bevy_pkv copied to clipboard

Published 20 hours ago • verified publisher icon johanhelsing

feat: Pickle DB Backend Support

Open nx2k3 opened this issue 1 year ago • 10 comments

This adds support for Pickle DB alternative backend for non-wasm based environments. #32

nx2k3 avatar Apr 18 '23 06:04 nx2k3

Is error handling done right

nx2k3 avatar Apr 18 '23 06:04 nx2k3

Are the tests passing locally for you?

johanhelsing avatar Apr 20 '23 08:04 johanhelsing

Are the tests passing locally for you?

yes they are passing

nx2k3 avatar Apr 20 '23 14:04 nx2k3

Hmm.. okay. We need to figure out why they are failing in ci, then. Which os are you on?

johanhelsing avatar Apr 20 '23 14:04 johanhelsing

Hmm.. okay. We need to figure out why they are failing in ci, then. Which os are you on?

arch linux wsl image

nx2k3 avatar Apr 20 '23 14:04 nx2k3

Okay i tried on windows, passing there as well.

Maybe it's some parent directory that needs to be created or something? What happens if you delete the app folder? Do the tests fail then?

Guess i could try this myself, but on the go now

johanhelsing avatar Apr 20 '23 17:04 johanhelsing

hey i think dump function is causing error

nx2k3 avatar Apr 21 '23 02:04 nx2k3

@johanhelsing I looked into pickledb source code, I might be wrong but it seems it loads the whole DB into memory which is a huge blocker for me to use.

Dimchikkk avatar May 06 '23 09:05 Dimchikkk

Ah, bummer. In either case, I don't plan on getting rid of the other backends.

Other suggestions for maintained rust-only native backends are welcome.

johanhelsing avatar May 06 '23 09:05 johanhelsing

hey I think its better to close this PR as redb support was added

nx2k3 avatar Oct 08 '23 07:10 nx2k3