Johan Brandhorst-Satzkorn

Results 600 comments of Johan Brandhorst-Satzkorn

Base64 encode the data in a string type maybe?

You'd have to encode it in the client anyway, you can't send raw bytes in a URL. If it's a uuid though, maybe just send the string representation of the...

If it's a path parameter, it has to be URL-encoded or base64-encoded and stored in a string. If it's in the body of the message, I guess you may still...

If you add it as a path param you don't need to add it to the body of the message. If existing clients are already sending the UUID in the...

Ah I see. In that case, maybe just make the uuid a parameter in the body instead? So you can reuse the same types. If that doesn't work, you will...

I frankly don't know, I'm afraid. Try it :man_shrugging:.

The easiest way to start working on a fix for this would be to create a failing test case. There are examples of tests lie this here: https://github.com/grpc-ecosystem/grpc-gateway/blob/master/protoc-gen-openapiv2/internal/genopenapi/template_test.go. The logic...

There's no particular reason you'd need to fix this on Windows. If it's fixed it will be fixed on all platforms.

Hm, I went looking at our existing example enums: https://github.com/grpc-ecosystem/grpc-gateway/blob/963f1aa09bbbcf62bacdf2e3d0d6c45c3f76d7e4/examples/internal/proto/examplepb/a_bit_of_everything.proto#L417-L423. This is rendered like so: https://github.com/grpc-ecosystem/grpc-gateway/blob/963f1aa09bbbcf62bacdf2e3d0d6c45c3f76d7e4/examples/internal/proto/examplepb/a_bit_of_everything.swagger.json#L4826-L4834. This includes all the comments in the description, and nothing in the title. Is...

Huh, I could've sworn I went and checked these. Thank you for your issue and the PR!