code icon indicating copy to clipboard operation
code copied to clipboard

FaviconizeGoogle and Instant Preview

Open boromyr opened this issue 4 years ago • 3 comments

Hi, I'm using FaviconizeGoogle script, but found a compatibility problem withInstant Preview,a Chrome extension. By disabling the script, the extension resumes working properly. Could you help me? I use Tampermonkey to load the script.

boromyr avatar Feb 08 '21 18:02 boromyr

Hi @boromyr that's a fun extension!

I guess you're having trouble on Google? Any other sites?

For Google, it looks like you can solve the problem by editing the FaviconizeGoogle script in Tampermonkey, and changing one of the following from false to true:

var placeFaviconByUrl      = false;
var placeFaviconAfter      = false;
var placeFaviconInsideLink = false;

Changing any one will work. And right now on Google it doesn't seem that they make much difference to the result.

But I'm not going to change the defaults in the script right now. Because that would change the behaviour for all users. And I would have to do some testing to check all the sites are still working.

I guess this is happening due to the way Instant Preview searches for the URL. We could also request a fix on their side. ;-)

joeytwiddle avatar Feb 16 '21 12:02 joeytwiddle

Perfect thank you, I solved the problem by only changing var placeFaviconByUrl = true;

What other sites are you referring to?

boromyr avatar Feb 19 '21 16:02 boromyr

What other sites are you referring to?

The script was originally designed for Google Search. But after requests, I added support for Ecosia, StartPage and Searx.

joeytwiddle avatar Mar 21 '21 01:03 joeytwiddle