Joey Parrish

@vinod-balakrishnan, I will re-review it today. Apologies for the delay. It is a complex PR, though, and review is difficult. We thank you for your contribution and your patience.

I'm very interested in this, but need to find time to give it the proper consideration. This issue is in my queue, though, and I'll give it a full read...

> * Shaka maintains the existing `MediaKeySession` object to be used with the new `MediaSource`. Unfortunately, I'm not certain this part would work. I could be wrong, so we can...

> That sounds ideal. Just to clarify, can we submit a PR without the intention of merging it, just so that we could get a run triggered with the device...

No worries on the PR naming convention. It prevents merge, but this wasn't meant to be merged as-is. And if you want to clean it up for merge later, you...

I am not aware of anyone working on either patch manifests or xlink onRequest. Today xlinks are only resolved immediately on parsing the manifest.

As far as I can tell, nobody is working on this yet, so it shouldn't be in the v4.1 milestone. I placed this enhancement in the backlog for now. As...

The errors thrown directly by that method are all `Severity.RECOVERABLE`, except `Code.MISSING_TEXT_PLUGIN`, which is `Severity.CRITICAL`. If an error is thrown from elsewhere, and bubbles up through this method, you could...

I just tried this in the demo to see what would happen: ```js player = video.ui.getControls().getLocalPlayer() player.addTextTrackAsync('foo.vtt', 'en', 'captions', 'text/vtt', '', '', false) ``` `foo.vtt` doesn't exist. The call succeeds...

Confirmed. I get no audio on Tizen 2017.