Joey Parrish
Joey Parrish
I would also like @littlespex to review this. This week, he and I discussed his plans for CMCD v2, so I want to make sure this does not complicate those...
Thank you for offering to fix it! Happy to have your contributions. I'll close #947 and leave a comment pointing to this issue explaining why we will make the change.
Thanks for contributing! For my own notes: I checked source in Shaka Player and found that HDR info is taken from both EssentialProperty and SupplementalProperty, in that order.
Looks like you have a small error in your tests: https://github.com/shaka-project/shaka-packager/actions/runs/19561994356/job/56079257646?pr=1524 ``` packager/app/test/packager_test.py:492:46: E0001: Parsing failed: 'invalid syntax. Perhaps you forgot a comma? (packager_test, line 492)' (syntax-error) ```
If you would allow us to make edits in the future, I would be happy to correct small issues like this myself. Let us know when you've pushed a commit...
> If you would allow us to make edits in the future... Not allowed by GitHub for organization forks, rather than personal ones! See https://github.com/shaka-project/shaka-packager/pull/1523#issuecomment-3564794548
https://github.com/shaka-project/shaka-packager/actions/runs/19586274341/job/56102029656?pr=1524 ``` ************* Module packager_test packager/app/test/packager_test.py:554:7: E0602: Undefined variable 'use_colorimetry_essential_property' (undefined-variable) packager/app/test/packager_test.py:493:16: W0613: Unused argument 'use_colorimetry_essentail_properity' (unused-argument) packager/app/test/packager_test.py:1502:12: E1123: Unexpected keyword argument 'use_colorimetry_essential_property' in method call (unexpected-keyword-arg) packager/app/test/packager_test.py:1521:12: E1123: Unexpected...
> Hi @marcoscaceres, I'm affiliated with @GoogleChrome, just updated my profile. If you are at Google, could you please check out go/github and register so that internally, we can associate...
This condition (`hardware-context-reset` on `closed`) should be triggerable with L1 content on Windows when putting the laptop to sleep.
Thanks! I'll help you get up to speed on the components in use here.