Sensor-Watch icon indicating copy to clipboard operation
Sensor-Watch copied to clipboard

Add page_face

Open WesleyAC opened this issue 1 year ago • 2 comments

This allows for organization of a large number of faces, by hiding some faces in a "page"

This seems like a better path forward for what I was trying to do with #314, although it's worth thinking at some point about how this might interact with something like #264 (since it currently wouldn't play nicely with that sort of system).

WesleyAC avatar Nov 09 '23 08:11 WesleyAC

any chance this could make it to main before movement overhaul? I've been running this PR for few months now on my watch with zero issues. Works really good for hiding settings/preferences.

chris-v8 avatar Aug 27 '24 08:08 chris-v8

@chris-v8 The feature freeze for the refactoring is due in September. I can't promise it'll make it in but I'll try. I need to review all the code and referenced PRs and see what we can do. It's also something that will significantly change the product's user experience so I cannot merge it without discussing that first.

I can tell you this is something I want personally. Right now movement has two hardcoded pages that we switch between by holding the button. I feel like it should be simple to generalize this mechanism so that we can have any number of pages.

In any case, thanks for testing it on real hardware, it's greatly appreciated and if it does get merged I'll make sure everyone's names are in the commit.

matheusmoreira avatar Aug 27 '24 09:08 matheusmoreira