chaiNNer icon indicating copy to clipboard operation
chaiNNer copied to clipboard

Published 20 hours ago • verified publisher icon joeyballentine

Undo gets "stuck" in text boxes

Open RunDevelopment opened this issue 2 years ago • 3 comments

This applies the fix for #661 to number inputs. I didn't apply it to text boxes so far.

RunDevelopment avatar Aug 17 '22 09:08 RunDevelopment

@RunDevelopment what is this waiting on?

joeyballentine avatar Aug 23 '22 13:08 joeyballentine

Feedback on whether we actually want to fix, because I think that the fix makes the UI worse.

RunDevelopment avatar Aug 23 '22 15:08 RunDevelopment

Ah, that does seem worse

joeyballentine avatar Aug 23 '22 15:08 joeyballentine

Could we commit text box changes to the undo history? I think that would solve the issue and make this not as bad of a change. Otherwise I think we should just close this PR

joeyballentine avatar Sep 14 '22 18:09 joeyballentine

Could we commit text box changes to the undo history

No. As Kim rightly pointed out, that's just a bad UX. We don't do that for other inputs (number) either, so it would be inconsistent on top of that.

Otherwise I think we should just close this PR

I agree. Let's just close it.

RunDevelopment avatar Sep 14 '22 20:09 RunDevelopment