chaiNNer icon indicating copy to clipboard operation
chaiNNer copied to clipboard

Upscale Image node's size changes

Open RunDevelopment opened this issue 2 years ago • 3 comments

The output label "Upscale Image" is quite long, so the type tag widens the node.

image

RunDevelopment avatar Aug 08 '22 14:08 RunDevelopment

This is more of a general problem that I've seen happen to other nodes, and it's going to continue to be an issue.

We either need to just deal with the fact that nodes can change size depending on what information gets added, or we need to make each node unreasonably large just in case they have big labels and type tags, which I think is a bit ridiculous and a waste of space.

That being said though, I think nodes should probably be at least as big as the width that having a text/number input makes them, since those nodes are typically wider

joeyballentine avatar Aug 08 '22 17:08 joeyballentine

Also, "upscaled image" can probably be changed to "result". I only did it that way since we didn't have any way of knowing the type in the olden days, so I wanted to include the word image

joeyballentine avatar Aug 08 '22 17:08 joeyballentine

I would just call them "Image" to make the Upscale nodes consistent with most of the other nodes. There are a few where we do things like specify what channels are input/output, but most nodes just say "Image".

theflyingzamboni avatar Aug 15 '22 18:08 theflyingzamboni

Fixed by #2111.

RunDevelopment avatar Aug 18 '23 11:08 RunDevelopment