chaiNNer icon indicating copy to clipboard operation
chaiNNer copied to clipboard

Add warning when modifying a currently running/paused chain

Open RunDevelopment opened this issue 2 years ago • 2 comments

What the title says. Users can edit chains while they are running or being paused. This potentially created multiple issues in the frontend code (all of these are bugs), but the main problem is that the user might get confused, as they might expect edits to parts that have yet to execute to be reflected in the final result.

RunDevelopment avatar Aug 04 '22 21:08 RunDevelopment

How do we think this should be implemented? I'm thinking just a little floating warning box at the top of the editor pane

joeyballentine avatar Aug 05 '22 09:08 joeyballentine

Agreed. That's what VS does as well.

RunDevelopment avatar Aug 05 '22 10:08 RunDevelopment

Looks like this feature was added in the recent update, however, I noticed a bug. When a pytorch model is used in an image iterator, it looks like the model information redisplays each time an image is processed. Not only does this cause the box for the "Load model" task to change size, but it also triggers a "modification" warning. This could also suggest a performance optimization if we really are reloading the model each time.

pokepress avatar Sep 05 '22 18:09 pokepress

@pokepress you are supposed to have the load image node outside of the iterator. Yes, it is a performance concern, and yes it is not intuitive. This is one of the reasons we want to change how iterators work.

However, there definitely is some sort of bug, as it does think that something is being changed under that scenario, even though nothing actually is. I am actively looking into it.

joeyballentine avatar Sep 05 '22 21:09 joeyballentine

Closing this as it was added in v0.12

joeyballentine avatar Sep 10 '22 21:09 joeyballentine