Joe Van Dyk

Results 45 comments of Joe Van Dyk
trafficstars

@alexdunae Any thoughts on either integrating the Rails 3 actionmailer hooks into premailer, or having a 'blessed' premailer-rails3 gem?

Great! By the way, I think the same problem can exist with 3 character hex (#fff). Safest thing is to probably convert all colors to six characters.

I think Rails 4 supports specifying the transaction level.. maybe that could be used?

@JacobEvelyn The tests probably aren't formatted exactly as they should be, but I think it illustrates the problem.

@JacobEvelyn any thoughts on this one?

Thanks for looking at this! To be honest, I don't know why the instance variable isn't always initialized. This fix is a bandaid for what I assume is properly initializing...

I am also running into this as well with esbuild, I have to remove the `--public-path` option from esbuild to get sourcemaps to work, otherwise sprockets-rails seems to remove the...

would the propshaft fix at https://github.com/rails/propshaft/pull/170 be applicable here?

Son of a bitch, nevermind. I was actually using 1.8.7 here. 'rvm info' lied to me.