Johannes Theiner
Johannes Theiner
[.mod-cta {](https://github.com/fabricehong/obsidian-prompt-crafter-plugin/blob/98f564cbac98fd1b308117dd2db75def42ad9c57/styles.css#L18), [.mod-cta:hover {](https://github.com/fabricehong/obsidian-prompt-crafter-plugin/blob/98f564cbac98fd1b308117dd2db75def42ad9c57/styles.css#L28) Please don't overwrite core styling in a plugin, add another class/data attribute so it only applies to your plugin. [// Remember to rename these classes and...
[containerEl.createEl('h2', { text: 'General Settings' });](https://github.com/MattSzymonski/Obsidian-Scratch-Map/blob/732b7aff8504ad1a0e1fa4f0b70ec0323fce7250/main.ts#L134) [Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Only+use+headings+under+settings+if+you+have+more+than+one+section.) --- [L.tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {](https://github.com/MattSzymonski/Obsidian-Scratch-Map/blob/732b7aff8504ad1a0e1fa4f0b70ec0323fce7250/main.ts#L80) Please mention...
Copying over the code review over from the other PR. ["authorUrl": "",](https://github.com/csdjk/lcl-obsidian-html-local-img-plugin/blob/a4540c83648c54edb977ca9761d9dd97f0ee2575/manifest.json#L8) This needs to be filled, if you don't have a website use your GitHub profile url ["fundingUrl": "",](https://github.com/csdjk/lcl-obsidian-html-local-img-plugin/blob/a4540c83648c54edb977ca9761d9dd97f0ee2575/manifest.json#L9)...
["description": "The simple plugin that automatically assigns a unique identifier (NID) to a note.",](https://github.com/dmitriy-bodroff/obsidian-nidifier-plugin/blob/e2936d4a36b0c9a804e0399414d6e905b05e0326/manifest.json#L6) Avoid including sentences like "This is a plugin that does ..." in your description, it should...
A link to https://docs.obsidian.md/Plugins/User+interface/Icons would be better.
[Copyright (c) 2023 Matthew Scott](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/LICENSE#L3) Update the year. ["fs": "^0.0.1-security",](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/package.json#L34) That is not a valid dependency, remove it. [console.log("Exporting paper");](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/src/main.ts#L33), [console.log(this.settings.base_output_folder);](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/src/main.ts#L41), [console.log("no preamble file found.");](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/src/main.ts#L71), [console.log("no bib file found.");](https://github.com/mscott99/Latex-Exporter/blob/b6b4a498a7d992a0552fcf257f22da3716353f0b/src/main.ts#L93), [console.log("Exporting...
Use: https://docs.obsidian.md/Reference/TypeScript+API/MetadataCache/getFirstLinkpathDest
You have not updated your license
Sorry for the delay in reviewing. Remove the `styles.css` file from your release, since it's empty it's just unnecessary bloat that Obsidian would download. [name: "Move Files to Folder",](https://github.com/UniqueClone/obsidian-file-organiser/blob/bd9f4ff2637f096ac884d0c81ec516a3a848a8eb/main.ts#L11) [Use...
[export function drawSteelAdmonitionPlugin(admonitions: DrawSteelAdmonition[]) {](https://github.com/scottTomaszewski/draw-steel-elements/blob/ddd0dae9ea90ad881dcc6d979024ac7f53780724/src/drawSteelAdmonition/drawSteelAdmonitionExtension.ts#L9-L48), [export class DrawSteelAdmonitionsPostProcessor {](https://github.com/scottTomaszewski/draw-steel-elements/blob/ddd0dae9ea90ad881dcc6d979024ac7f53780724/src/drawSteelAdmonition/drawSteelAdmonitionPostProcessor.ts#L5-L18) Shouldn't this be a [MarkdownCodeBlockPostProccessor](https://docs.obsidian.md/Plugins/Editor/Markdown+post+processing#Post-process+Markdown+code+blocks) ? [const yaml = YAML.parse(codeElement.getText());](https://github.com/scottTomaszewski/draw-steel-elements/blob/ddd0dae9ea90ad881dcc6d979024ac7f53780724/src/drawSteelAdmonition/powerRollAdmonition.ts#L29) Use the `parseYaml` function from the Obsidian API instead of importing...