python-oauth2 icon indicating copy to clipboard operation
python-oauth2 copied to clipboard

Split client out of main __init__.py file

Open rlotun opened this issue 14 years ago • 5 comments

The current structure of the library mixes OAuth signing tools with http client library code - specifically synchronous http library code. We use Twisted, and would like to use all the great signing code without having to have httplib2 installed.

I'm thinking it might be nicer to have it moved to the clients sub-package and possibly have some import logic in init.py with a try/except ImportError around httplib2.

rlotun avatar Dec 02 '10 16:12 rlotun

Yeah I ran into this issue as well. Ended up forking the library and moving the client and server into their own modules. This way I avoid that hard dependency on httplib2.

Got nothing against httplib2, I just don't use the OAuth Client or httplib2 directly.

joshthecoder avatar Nov 13 '11 00:11 joshthecoder

Fork no longer exists but a valid request none-the-less. Thoughts @joestump?

jaitaiwan avatar Jul 29 '15 12:07 jaitaiwan

I agree we should split up the monolith that is __init__.py. Was just thinking about that this morning.

joestump avatar Jul 29 '15 16:07 joestump

Easy enough for 1.9RC1 or schedule for 2.0?

jaitaiwan avatar Jul 29 '15 22:07 jaitaiwan

I think we should get 1.9RC1 out with as many bug fixes so my vote is to save this work for 2.0.

joestump avatar Aug 02 '15 20:08 joestump