lift-ng icon indicating copy to clipboard operation
lift-ng copied to clipboard

debugInfoEnabled(false) conflicts with AngularActor and broadcast/emit

Open rofreytag opened this issue 7 years ago • 5 comments

Hey there!

As described in the angular documentation I configured my app for production use like this:

anglar.module('app').config(['$compileProvider', function ($compileProvider) {
  $compileProvider.debugInfoEnabled(false);
}]);

When doing this, I cannot getAngularActor to work. Specifically scope.broadcastand emit do nothing. My guess is, lift-ng uses some angular routines that are considered debug-only, like $element.scope().

Tell me if you have problems reproducing. Regards Robert

rofreytag avatar Jan 25 '18 11:01 rofreytag

Thanks for the report, Robert! I'm not yet sure if I'll laugh or cry if it turns out lift-ng can't work when angular is in production mode. Hopefully I can investigate soon.

joescii avatar Feb 23 '18 20:02 joescii

Seems to me that I'll have to go back to the drawing board because according to this issue, it's just how it is.

Just thinking on the top of my head, I suspect I could rewrite future/promise support to use Lift 3's round trips once I drop 2.x support (could do that really soon). Not entirely sure about the binding actors tho.

joescii avatar Feb 26 '18 15:02 joescii

After talking to you online earlier, I reviewed that issue above and borrowed a directive that seems to make some of the cases work. I'm still sorting through all the features that were depending on this debug mode, but looks promising thus far.

joescii avatar Feb 26 '18 22:02 joescii

Glad I could give some directions here!

rofreytag avatar Feb 27 '18 12:02 rofreytag

Got a working version here: #41 Take it for a spin when you get time.

joescii avatar Mar 06 '18 16:03 joescii