joern icon indicating copy to clipboard operation
joern copied to clipboard

ignore case while matching excluded files

Open Ferada opened this issue 1 year ago • 0 comments

Otherwise specifying one variant might not match the same file on e.g. Windows systems, when in fact it should match. This PR replaces the path comparisons with case-insensitive ones.

Test cases are happy, but I don't have a Windows one to test this. Ideally the comparisons should be purely on the paths, but instead there's an isDirectory call in there - it might be better (faster) to require callers to specify the ending slash / for directories instead and get rid of that case.

c.f. https://shiftleft.zendesk.com/agent/tickets/102700 and https://shiftleftsecurity.slack.com/archives/CE822HDC1/p1719386396027259

https://shiftleftinc.atlassian.net/browse/SEN-2828

Ferada avatar Jun 27 '24 09:06 Ferada