Jörn Heissler

> Why TOML? There are some arguments here, most of which I support: https://gist.github.com/njsmith/78f68204c5d969f8c8bc645ef77d4a8f What's missing are the security issues of YAML (never use `yaml.load`!). Aside from that, I don't...

Hi, the error message could be clearer, but is there any real problem? You're getting an exception for malformed input. Sounds fine to me.

https://github.com/wbond/asn1crypto/blob/master/asn1crypto/core.py#L159 `raises ValueError - when the ASN.1 header length is longer than the data`. I expect (really not sure) that all parser errors will be some `ValueError`.

> `IndexError` isn't a `ValueError`. whoops :-)

This works: ```python3 cri['attributes'] = csr.CRIAttributes([]) ```

Those snippets run with `"optional": False` and `"optional": True`: ```python3 #!/usr/bin/env python3 from base64 import b64decode, b64encode from asn1crypto.csr import CertificationRequestInfo from asn1crypto.keys import PublicKeyInfo from asn1crypto.x509 import Name pub...

> The encoding from `a` seems to be correct > > The one from `b` seems incorrect, as it has appending a `Null` item to the end I think `b`...

> It doesn't sound to me like `optional` is broken, at all, if it lets you omit a field. That is the whole point. I mean if I set `'optional':...

What is "CDR"? The problem you're trying to solve looks similar to #152.

> Is there any more effective use of buffers where I would use pointers instead of a new object Python brings a bytearray object which has efficient append/remove operations on...