SQHell.vim icon indicating copy to clipboard operation
SQHell.vim copied to clipboard

MySQL provider doesn't work with an empty password

Open tofulm opened this issue 7 years ago • 4 comments

Hello, My default config of mysql has an empty password.

the prompt ask the password but it's not possible to write it down.

With Neovim 2.3

tofulm avatar Dec 11 '17 20:12 tofulm

Hey,

Thanks for the report! I'll take a look

joereynolds avatar Dec 11 '17 21:12 joereynolds

  • [ ] Allow command to work with and without password
  • [ ] Fix postBufferFormat behaviour
  • [ ] Fix 'e' on SQHResult buffer
  • [x] Refactor getDatabaseName
  • [ ] Tests that check mysql works with and without a password (if one is not set)
  • [x] Tests that check for Tables_in_ anywhere in the buffer, not necessarily the first line
  • [x] Tests for postBufferFormat (buffers that show the password warnings, buffers with just a newline, and a normal buffer)

joereynolds avatar Dec 11 '17 21:12 joereynolds

Hey, I also ran into this issue (empty password doesn't work with MYSQL provider).

I think the fix is as easy replacing this with:

let l:password = '--password=' . a:password . ' '

I can send a PR, but I'm not sure about the items checked in your comment?

deeuu avatar Nov 22 '18 10:11 deeuu

Hey @deeuu,

You're welcome to raise a PR, don't worry about the items in my comment, those are ongoing, though if you can add some tests around the area that'd be great :D

Thanks :)

joereynolds avatar Nov 22 '18 13:11 joereynolds