DotNetLightning icon indicating copy to clipboard operation
DotNetLightning copied to clipboard

Mutable collections are causing race conditions

Open knocte opened this issue 5 years ago • 2 comments

See https://github.com/joemphilips/DotNetLightning/runs/695486967

(We should use Map instead of ConcurrentDictionary.)

knocte avatar May 22 '20 05:05 knocte

I'm not 100% sure if the mutable collection is what causing this. It may be something specific in Infrastructure tests. Anyway, #98 might be a solution if it is too hard to debug.

joemphilips avatar May 22 '20 05:05 joemphilips

I'd like to know Andrew's opinion on getting rid of Infrastructure project and tests before we nuke it. However, regardless of that, I think switching to immutable collections is still a worthy change.

knocte avatar May 22 '20 05:05 knocte