Joe Bryan

Results 147 comments of Joe Bryan

FWIW, I'm a fan of [standard](https://github.com/standard/standard) (which is an eslint configuration, but packaged so that it's *not* easy to change).

That's supposed to happen via URL params; I'll investigate.

Is there a record of that decision somewhere? I feel like deep linking is pretty important.

Can we get a test case or detailed description of the circumstances under which the search state is not preserved? The current search controller inherits from `MLSearchController`, which automatically handles...

> Then go to Create, and back to Search. Go back how? By clicking a static link to `/search`? Hitting the back button?

The question is, should that be the default behavior? I like resetting the context when I navigate to `/search`, and I think it's how most web apps behave.

Is there a demo available now that exhibits the behavior you want?

I think it'd be good to have the functionality in ml-search-ng, but I'm not sure exactly where it should go. I guess it wouldn't be too hard to bake it...

#449 uses a very similar approach (cache-related headers applied as express middleware). It'd be really easy to just use this module instead. NBD either way ...

The search response is already persisted to `mlSearch.results`, so if you use that, you could simplify the implementation (at least be removing the override of `ctrl.updateSearchResults()`. As for the search...