railsdevs.com icon indicating copy to clipboard operation
railsdevs.com copied to clipboard

Published 20 hours ago • verified publisher icon joemasilotti

Link to conversations from developer and business pages #602

Open xmarlox opened this issue 2 years ago • 3 comments

Link to conversations from developer and business pages #602

  • Use grid for pills button with 3 actions per row in Admin section of developer & business profile pages
  • Change the link of developer & business to its corresponding show/profile page in Users list page

Pull request checklist

  • [x] I linted and tested the project with bin/check

xmarlox avatar Sep 23 '22 15:09 xmarlox

Thanks for your contribution!

I'm having second guesses on if the two rows of pills is the right approach now. I wouldn't have known it without seeing it, so thanks for taking the time to wire it up!

Let's revert back to the single pill of 3 buttons. And add a link to "View conversations" underneath them. I think this makes more sense both visually and behaviorally - actions do things and links visit a page.

I understand I took a while to review this PR. Let me know if you still have appetite to take it over the finish line. If not, no worries! I can take over.

joemasilotti avatar Oct 18 '22 20:10 joemasilotti

@joemasilotti it's ok, i can change it accordingly.

xmarlox avatar Oct 20 '22 08:10 xmarlox

@joemasilotti already addressed your PR comments. let me know if there still need to change. thanks! 😃

xmarlox avatar Oct 20 '22 12:10 xmarlox

@xmarlox, do you still have appetite to finish this? If not, no worries! I can assign it to someone else.

If I don't hear back in a few days I'll close this PR.

joemasilotti avatar Nov 28 '22 14:11 joemasilotti