railsdevs.com icon indicating copy to clipboard operation
railsdevs.com copied to clipboard

Set pagination page size to 10 (from 20) for `/developers`

Open joemasilotti opened this issue 2 years ago • 8 comments

Note that the global pagination configuration should not be changed. The code change will most likely occur somewhere in DeveloperQuery.

joemasilotti avatar Sep 16 '22 05:09 joemasilotti

Hey Joe, I would like to take a shot at this.

wlw1227 avatar Sep 17 '22 14:09 wlw1227

Sure thing, all yours @wlw1227!

joemasilotti avatar Sep 17 '22 21:09 joemasilotti

@joemasilloti are there any updates on this one? if none, i'd love to work on this thanks!

xmarlox avatar Sep 28 '22 14:09 xmarlox

I believe I got the pagination figured out, but I am having trouble writing the test, if @xmarlox or @joemasilotti would be willing to help I would appreciate it.

wlw1227 avatar Sep 28 '22 14:09 wlw1227

sure no worries @wlw1227

which branch are you using? or if it’s a fork, can you send the url and branch you’re using to work on this issue.

so, i can pull your changes and create tests accordingly

xmarlox avatar Sep 28 '22 15:09 xmarlox

@xmarlox thank u!

I’ll send that your way in the morning, I won’t be in front of my computer today

wlw1227 avatar Sep 28 '22 15:09 wlw1227

https://github.com/wlw1227/railsdevs.com/tree/change-developer-pagination

@xmarlox here's the fork and branch I'm using

wlw1227 avatar Sep 29 '22 09:09 wlw1227

@joemasilotti @wlw1227 here's the PR to address this issue 😃

xmarlox avatar Sep 30 '22 22:09 xmarlox